update svelto common

com.sebaslab.svelto.common

@@ -1 +1 @@
-Subproject commit ff24942680a5e5d257541ed857a140e62525fe45
+Subproject commit 0c123edc4b74ff8d2c2be79b8f64ce9e996f856a

com.sebaslab.svelto.ecs/Core/EnginesRoot.Engines.cs

@@ -1,5 +1,5 @@
 #if PROFILE_SVELTO && DEBUG
-#warning the global define PROFILE_SVELTO should be used only when it's necessary to profile in order to reduce the overhead of debug code. Normally remove this define to get insights when errors happen
+#warning the global define PROFILE_SVELTO should be used only when it's necessary to profile in order to reduce the overhead of debug code. While debugging remove this define to get insights when errors happen
 #endif
 
 using System;

com.sebaslab.svelto.ecs/Core/EntityViewUtility.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using Svelto.DataStructures;
-using Svelto.ECS.Hybrid;
 using Svelto.ECS.Internal;
 using Svelto.Utilities;
 

com.sebaslab.svelto.ecs/Extensions/Unity/DOTS/UECS/DOTSOperationsForSvelto.cs

@@ -177,7 +177,6 @@ namespace Svelto.ECS.SveltoOnDOTS
             _EManager.AddComponent<T>(DOTSEntities);
         }
 
-        //can't support publicly the version without DOTSSveltoEGID now
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         NativeArray<Entity> CreateDOTSEntityFromSveltoBatched(Entity prefab, (uint rangeStart, uint rangeEnd) range,
             ExclusiveGroupStruct groupID, NB<DOTSEntityComponent> DOSTEntityComponents)
@@ -197,7 +196,8 @@ namespace Svelto.ECS.SveltoOnDOTS
                     _EManager.AddSharedComponentData(nativeArray[i], new DOTSSveltoGroupID(groupID));
                 }
 #endif
-
+                //Set Svelto DOTSEntityComponent dotsEntity field to the DOTS entity
+                //Svelto entities track the DOTS entities through this component
                 var setDOTSEntityComponentsJob = new SetDOTSEntityComponents
                 {
                     sveltoStartIndex = range.rangeStart,
@@ -219,9 +219,11 @@ namespace Svelto.ECS.SveltoOnDOTS
             {
                 var count = (int)(range.rangeEnd - range.rangeStart);
                 
+                //DOTS entities track Svelto entities through this component
                 _EManager.AddComponent<DOTSSveltoEGID>(nativeArray);
 
-                var SetDOTSSveltoEGIDJob = new SetDOTSSveltoEGID
+                //set the DOTSSveltoEGID values
+                var setDOTSSveltoEGIDJob = new SetDOTSSveltoEGID
                 {
                     sveltoStartIndex = range.rangeStart,
                     createdEntities = nativeArray,
@@ -229,7 +231,7 @@ namespace Svelto.ECS.SveltoOnDOTS
                     ids = sveltoIds,
                     groupID = groupID
                 };
-                creationJob = *_jobHandle = JobHandle.CombineDependencies(*_jobHandle, SetDOTSSveltoEGIDJob.ScheduleParallel(count, default));
+                creationJob = *_jobHandle = JobHandle.CombineDependencies(*_jobHandle, setDOTSSveltoEGIDJob.ScheduleParallel(count, default));
 
                 return nativeArray;
             }

com.sebaslab.svelto.ecs/Extensions/Unity/DOTS/UECS/SveltoOnDOTSCreationEngine.cs

@@ -11,7 +11,7 @@ namespace Svelto.ECS.SveltoOnDOTS
 
         string name { get; }
 
-        //use case is i.e. to create archetypes once
+        //use case is i.e. to create DOTS archetypes once
         void OnOperationsReady();
         //use case is i.e. to operate once per submission on entities just created
         void OnPostSubmission();

com.sebaslab.svelto.ecs/Extensions/Unity/DOTS/UECS/SveltoOnDOTSEnginesGroup.cs

@@ -20,7 +20,7 @@ namespace Svelto.ECS.SveltoOnDOTS
     /// Submission of Entities to be executed
     /// Svelto Add/Remove callbacks to be called
     /// ISveltoOnDOTSStructuralEngine to be executed
-    /// DOTS ECS engines to executed
+    /// DOTS ECS engines to be executed
     /// Synchronizations engines to be executed (DOTS ECS To Svelto)
     /// </summary>
     [Sequenced(nameof(JobifiedSveltoEngines.SveltoOnDOTS))]
@@ -39,6 +39,11 @@ namespace Svelto.ECS.SveltoOnDOTS
         /// for the user to add pure DOTS ECS SystemBase/ISystem systems to the DOTS ECS world
         /// </summary>
         public World world { get; private set; }
+        
+        /// <summary>
+        /// for the user to be able to explicitly submit entities. When SveltoOnDOTS is used, you must use this way, you cannot
+        /// submit entities directly from the EnginesRoot submission scheduler
+        /// </summary>
         public ISveltoOnDOTSSubmission submitter => _sveltoDotsEntitiesSubmissionGroup;
 
         public JobHandle Execute(JobHandle inputDeps)

com.sebaslab.svelto.ecs/package.json

@@ -11,7 +11,7 @@
     "url": "https://github.com/sebas77/Svelto.ECS.git"
   },
   "dependencies": {
-    "com.sebaslab.svelto.common": "3.4.0"
+    "com.sebaslab.svelto.common": "3.4.1"
   },
   "keywords": [
     "svelto",
@@ -19,7 +19,7 @@
     "svelto.ecs"
   ],
   "name": "com.sebaslab.svelto.ecs",
-  "version": "3.4.2",
+  "version": "3.4.3",
   "type": "library",
   "unity": "2020.3"
 }

com.sebaslab.svelto.ecs/version.json

@@ -1,3 +1,3 @@
 {
-  "version": "3.4.2"
+  "version": "3.4.3"
 }